Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix colorama not being disabled after being used #586

Merged
merged 1 commit into from Mar 10, 2020
Merged

Fix colorama not being disabled after being used #586

merged 1 commit into from Mar 10, 2020

Conversation

adambenali
Copy link
Contributor

Fixes #580.
This makes sure colorama is properly disabled.

@lukehinds lukehinds self-requested a review March 10, 2020 09:17
lukehinds
lukehinds approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a windows machine to test this, but the logic flow looks right to me.

@lukehinds lukehinds merged commit 5a1c4f0 into PyCQA:master Mar 10, 2020
@ericwb
Copy link
Member

ericwb commented Mar 12, 2020

I suggest we also officially unit test on windows platform in order to claim support of that platform.

@ericwb ericwb added this to the Release 1.6.3 milestone Dec 6, 2020
@renovate renovate bot mentioned this pull request Mar 7, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehinds lukehinds lukehinds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.6.3
Development

Successfully merging this pull request may close these issues.

Importing bandit messes up console output on Windows.
3 participants
@adambenali @ericwb @lukehinds