Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve 'NoneType' object has no attribute 'id'Traceback in django_mark_safe #598

Merged
merged 1 commit into from Apr 16, 2020

Conversation

ehooo
Copy link
Contributor

@ehooo ehooo commented Apr 13, 2020

Fix NoneType exception when with statement don't contains as

@lukehinds
Copy link
Member

thanks @ehooo , tested ok for me, you just ave a PEP8 violation to fix up:

E501 line too long (87 > 79 characters)
                    if getattr(withitem.optional_vars, 'id', None) == self.var_name.id:
                                                                               ^

@lukehinds lukehinds changed the title Fix issue #574 Resolve 'NoneType' object has no attribute 'id'Traceback in django_mark_safe Apr 13, 2020
Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Can you please put more detail in the PR message. It's blank at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants