New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove universal support on the wheel #655
Conversation
Now that Bandit is Py3 only, it should be considered a "Pure-Python Wheel" instead of a "Universal". Further information can be found here: https://realpython.com/python-wheels/#specifying-a-universal-wheel Fixes #654 Signed-off-by: Eric Brown <browne@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will let you merge as you may have some sort of merge order in mind.
I'm 90% certain we actually want to keep this as this tells pip that this is "universal" for all versions of Python 3 we support |
PyCQA/pyflakes#597 (comment) gives me that 90% certainty and 10% uncertainty |
According to https://realpython.com/python-wheels/#different-types-of-wheels, this is still considered a pure python wheel, just one that doesn't support py2.
|
Looking at https://packaging.python.org/guides/distributing-packages-using-setuptools/#pure-python-wheels you do appear to be correct. I've found enough misinformation on realpython.com to not trust it |
Now that Bandit is Py3 only, it should be considered a "Pure-Python Wheel" instead of a "Universal". Further information can be found here: https://realpython.com/python-wheels/#specifying-a-universal-wheel Fixes PyCQA#654 Signed-off-by: Eric Brown <browne@vmware.com> Co-authored-by: Luke Hinds <7058938+lukehinds@users.noreply.github.com>
Now that Bandit is Py3 only, it should be considered a "Pure-Python Wheel" instead of a "Universal". Further information can be found here: https://realpython.com/python-wheels/#specifying-a-universal-wheel Fixes PyCQA#654 Signed-off-by: Eric Brown <browne@vmware.com> Co-authored-by: Luke Hinds <7058938+lukehinds@users.noreply.github.com>
Now that Bandit is Py3 only, it should be considered a "Pure-Python
Wheel" instead of a "Universal". Further information can be found
here: https://realpython.com/python-wheels/#specifying-a-universal-wheel
Fixes #654
Signed-off-by: Eric Brown browne@vmware.com