django_rawsql_used: support keyword arguments used in RawSQL
#765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinmarsh
requested review from
ericwb,
ghugo,
lukehinds and
sigmavirus24
as code owners
kevinmarsh
force-pushed
the
fix-B611-keyword-args
branch
from
e07b9f7
to
d18982b
Compare
|
Is it possible to try and progress this? Presumably we just need an approving review plus a rebase (to get the checks running and passing). |
kevinmarsh
force-pushed
the
fix-B611-keyword-args
branch
from
d18982b
to
c79b679
Compare
|
Have rebased and pushed the fix, this is still causing noise/breaking if someone can please approve running the workflows/checks so this issue can be resolved? |
Fix rule B611: django_rawsql_used breaking when a user passes in keyword arguments to Django's `RawSQL`. Resolves: PyCQA#764
kevinmarsh
force-pushed
the
fix-B611-keyword-args
branch
from
c79b679
to
f2f46cc
Compare
|
Just rebased again and all checks pass on my fork: https://github.com/kevinmarsh/bandit/actions/runs/5648344872 |
sigmavirus24
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rule B611: django_rawsql_used breaking when a user passes in keyword arguments to Django's
RawSQL.Closes #764