Add new plugin to check use of pyghmi #795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch set adds a new bandit plugin to check the use of pyghmi. Signed-off-by: Tin Lam <tin@irrational.io>
Signed-off-by: Tin Lam <tin@irrational.io>
This patch set adds a new bandit plugin to check the use of the pyghmi library, as the IPMI is known to be an insecured protocol. Closes: PyCQA#356 Signed-off-by: Tin Lam <tin@irrational.io>
ericwb
requested review from
ghugo,
lukehinds and
sigmavirus24
as code owners
sigmavirus24
reviewed
Feb 5, 2022
| if context.is_module_imported_like(module): | ||
| return bandit.Issue( | ||
| severity=bandit.MEDIUM, | ||
| confidence=bandit.MEDIUM, |
There was a problem hiding this comment.
I resurrected this old commit from @stannum-l as a way to get the issue resolved. Yep, it'll need further work.
ericwb
commented
Feb 6, 2022
| @@ -224,6 +224,7 @@ Usage:: | |||
| B412 import_httpoxy | |||
| B413 import_pycrypto | |||
| B414 import_pycryptodome | |||
| B415 pyghmi | |||
There was a problem hiding this comment.
Suggested change
| B415 pyghmi |
|
Created a better PR in #803 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set adds a new bandit plugin to check the use of pyghmi.
Closes #356
Signed-off-by: Tin Lam tin@irrational.io