Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for deprecated TLS 1.1 #928

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Check for deprecated TLS 1.1 #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions bandit/plugins/insecure_ssl_tls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ def gen_config(name):
"PROTOCOL_TLSv1", # strict option
"SSLv3_METHOD", # strict option
"TLSv1_METHOD",
"PROTOCOL_TLSv1_1",
"TLSv1_1_METHOD",
]
} # strict option

Expand Down Expand Up @@ -106,6 +108,9 @@ def ssl_with_bad_version(context, config):
.. versionchanged:: 1.7.3
CWE information added

.. versionchanged:: 1.7.5
Added TLS 1.1

"""
bad_ssl_versions = get_bad_proto_versions(config)
if context.call_function_name_qual == "ssl.wrap_socket":
Expand Down Expand Up @@ -196,6 +201,9 @@ def ssl_with_bad_defaults(context, config):
.. versionchanged:: 1.7.3
CWE information added

.. versionchanged:: 1.7.5
Added TLS 1.1

"""

bad_ssl_versions = get_bad_proto_versions(config)
Expand Down
12 changes: 11 additions & 1 deletion examples/ssl-insecure-version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
herp_derp(method=SSL.SSLv3_METHOD)
herp_derp(method=SSL.TLSv1_METHOD)

ssl.wrap_socket(ssl_version=ssl.PROTOCOL_TLSv1_1)
SSL.Context(method=SSL.TLSv1_1_METHOD)

herp_derp(ssl_version=ssl.PROTOCOL_TLSv1_1)
herp_derp(method=SSL.TLSv1_1_METHOD)


ssl.wrap_socket()

def open_ssl_socket(version=ssl.PROTOCOL_SSLv2):
Expand All @@ -31,6 +38,9 @@ def open_ssl_socket(version=SSL.SSLv2_METHOD):
def open_ssl_socket(version=SSL.SSLv23_METHOD):
pass

# this one will pass ok
def open_ssl_socket(version=SSL.TLSv1_1_METHOD):
pass

# this one will pass ok
def open_ssl_socket(version=SSL.TLSv1_2_METHOD):
pass
8 changes: 2 additions & 6 deletions tests/functional/test_functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,12 +454,8 @@ def test_sql_statements(self):
def test_ssl_insecure_version(self):
"""Test for insecure SSL protocol versions."""
expect = {
"SEVERITY": {"LOW": 1, "MEDIUM": 10, "HIGH": 7},
"CONFIDENCE": {"LOW": 0, "MEDIUM": 11, "HIGH": 7},
}
expect = {
"SEVERITY": {"UNDEFINED": 0, "LOW": 1, "MEDIUM": 10, "HIGH": 7},
"CONFIDENCE": {"UNDEFINED": 0, "LOW": 0, "MEDIUM": 11, "HIGH": 7},
"SEVERITY": {"UNDEFINED": 0, "LOW": 1, "MEDIUM": 13, "HIGH": 9},
"CONFIDENCE": {"UNDEFINED": 0, "LOW": 0, "MEDIUM": 14, "HIGH": 9},
}
self.check_example("ssl-insecure-version.py", expect)

Expand Down