add a new style, "fromsfirst" #153
Conversation
| @@ -51,6 +51,7 @@ | |||
| 'appnexus = flake8_import_order.styles:AppNexus', | |||
| 'edited = flake8_import_order.styles:Edited', | |||
| 'pycharm = flake8_import_order.styles:PyCharm', | |||
| 'fromsfirst = flake8_import_order.styles:FromsFirst', | |||
There was a problem hiding this comment.
I believe this could be distributed as a separate style-plugin to flake8-import-order. It's unclear to me whether the maintainers want to maintain another style on top of what they already maintain.
There was a problem hiding this comment.
Yeah, but I had hoped to not have to have yet another thing in my github. My preference would be to land this here, if that’s acceptable.
There was a problem hiding this comment.
@dcrosta that sounds like you're saying you want to throw this over the wall for someone else to have to maintain. I'd encourage you to watch one of the keynotes from this year's PyCon as to why that's problematic.
I wonder what the plugin maintainers think about adding authors of these styles to the repo and using CODEOWNERs to denote maintainers. That could strike a balance of having people involved with the project without putting all the burden of maintainership on the existing miniscule team.
There was a problem hiding this comment.
I wouldn't characterize it quite that way. I think there are benefits for it living in the main repo -- it's more obvious to users that there are other styles, and simpler for them to use if they want this style.
That said, ultimately this is the maintainers' call. I won't be upset if they say no.
|
Please refer to the discussion in #163. |
Is there a well-known name for this style? Or just a better name? I'm open to suggestions