Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sys.stdlib_module_names #198

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Dreamsorcerer
Copy link
Contributor

@Dreamsorcerer Dreamsorcerer commented Dec 2, 2022

Fix #184, fix #175 and similar, once and for all (atleast once support for Python 3.9 is dropped).

@Dreamsorcerer
Copy link
Contributor Author

OK, these are in the old list, but not in sys.stdlib_module_names:

{'imgfile', 'fpformat', 'SimpleXMLRPCServer', 'aetools', 'aetypes', 'dummy_threading', 'httplib', 'future_builtins', 'bsddb', 'commands', 'mhlib', 'gl', 'user', 'macostools', 'imputil', 'DEVICE', 'cd', 'Queue', 'whichdb', 'autoGIL', 'dbhash', 'parser', 'CGIHTTPServer', 'fm', 'dircache', 'Mapping', '__builtin__', 'Cookie', 'cookielib', 'UserString', 'sha', 'UserDict', 'al', 'anydbm', 'formatter', 'fl', 'dl', 'Sequence', 'SimpleHTTPServer', 'aepack', 'hotshot', 'thread', 'Binary', 'SUNAUDIODEV', 'EasyDialogs', 'GL', 'findertools', 'repr', 'symbol', 'Bastion', 'xmlrpclib', 'ScrolledText', 'sunaudiodev', '_dummy_thread', 'rexec', 'robotparser', 'mimify', 'StringIO', 'MacOS', 'BaseHTTPServer', 'fpectl', 'Boolean', 'Tix', 'Numeric', 'new', 'gensuitemodule', 'DocXMLRPCServer', 'MiniAEFrame', 'Set', 'mimetools', 'macurl2path', 'gdbm', 'flp', 'UserList', 'md5', 'multifile', 'htmlentitydefs', 'cPickle', 'jpeg', 'sets', 'dummy_thread', 'ttk', 'posixfile', 'test', 'cStringIO', 'urllib2', 'ConfigParser', 'FL', 'MimeWriter', 'FrameWork', 'macpath', 'statvfs', 'os2emxpath', 'urlparse', 'ic', 'Text', 'SocketServer', 'htmllib', 'copy_reg', 'HTMLParser', 'Tkinter', 'rfc822', 'imageop', 'popen2', 'dumbdbm', '__main__', 'sgmllib', 'ColorPicker', 'mutex', 'AL'}

@Dreamsorcerer
Copy link
Contributor Author

Dreamsorcerer commented Dec 2, 2022

Almost all of them are old Python 2 modules. These are the ones that I can't see in the Python 2 docs, so no idea where these came from:
{'_dummy_thread', 'Text', 'macurl2path', 'Boolean', 'Binary', 'Set', 'os2emxpath', 'Numeric', 'Mapping', 'Sequence'}

Plus __main__ which should be added, and test, which is available in Python 3, but is not included in the list for some reason..

@@ -4,7 +4,6 @@
from functools import *
import os
from os import path
import StringIO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no stdlib modules in Py3 that start with an uppercase character, so I think this just has to be removed from the tests.

@Dreamsorcerer
Copy link
Contributor Author

That should help reduce maintenance in future anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support graphlib _csv is identified as Third Party instead of Stdlib
1 participant