Issue/1389/ensure new line before comments bug #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes existing test's configuration so it has no lines between sections. The default of 1 masks the error.
sztamas
commented
Aug 18, 2020
| @@ -172,6 +166,9 @@ def sorted_imports( | |||
| else: | |||
| pending_lines_before = pending_lines_before or not no_lines_before | |||
|
|
|||
| if config.ensure_newline_before_comments: | |||
There was a problem hiding this comment.
Wasn't sure whether we want to insert an empty line before on a comment above the first import as well.
It looks a bit strange to me to have it there, so I opted for not having an empty line in this special case.
In case you want it just move these 2 lines below the stripping of empty lines that follows next. I tested that it works there as well.
Codecov Report
@@ Coverage Diff @@
## develop #1390 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 2481 2488 +7
=========================================
+ Hits 2481 2488 +7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1389.