Depend on setuptools #1875
Closed
Depend on setuptools #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added a commit
to cisagov/log4j-md-yml
that referenced
this pull request
Dec 28, 2021
This PR resolves PyCQA/isort#1874, which is currently biting us when we attempt to install the isort pre-commit hook.
wolfit
approved these changes
Dec 28, 2021
|
This is not an isort specific issue. isort hasn't made any releases that change this behavior, and in fact hasn't made any release in some months. It also has no external dependencies. isort uses poetry intentionally and not setuptools, this change would misrepresent how isort should be installed.This breakage is occurring upstream and I encourage you to reach out to the projects responsible, and in the meantime utilize |
mcdonnnj
added a commit
to cisagov/log4j-md-yml
that referenced
this pull request
Dec 29, 2021
This reverts commit 51752ee.
jsf9k
pushed a commit
to cisagov/log4j-md-yml
that referenced
this pull request
Dec 29, 2021
This reverts commit 51752ee.
jsf9k
pushed a commit
to cisagov/log4j-md-yml
that referenced
this pull request
Dec 29, 2021
This reverts commit 51752ee. The workaround added in that commit is no longer required, since the issue was fixed in setuptools 60.1.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1874