Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compile to Apple universal2 in the other platform #1613

Merged
merged 1 commit into from May 17, 2023

Conversation

MisLink
Copy link
Contributor

@MisLink MisLink commented May 16, 2023

Since the --universal2 option is deprecated, only providing --target=universal2-apple-darwin cannot set the correct target for Linux or Windows platforms. I suggest that we disregard the current target if the user specifies the universal2-apple-darwin target.

Signed-off-by: MisLink <gjq.uoiai@outlook.com>
@netlify
Copy link

netlify bot commented May 16, 2023

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 075bed8
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6463bbb37b1ffd0008e91819
😎 Deploy Preview https://deploy-preview-1613--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MisLink MisLink changed the title Fix cross-compile to MacOS universal2 in the other platform Fix cross-compile to Apple universal2 in the other platform May 16, 2023
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, thanks!

@messense messense merged commit 7237fac into PyO3:main May 17, 2023
32 checks passed
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 21, 2023
https://build.opensuse.org/request/show/1088131
by user mia + dimstar_suse
- Update to v0.15.3:
  * Fix cross-compile to Apple universal2 in the other platform
    gh#PyO3/maturin#1613
  * Remove serde(flatten) to improve error messages
    gh#PyO3/maturin#1616
  * Allow syn 2.0
    gh#PyO3/maturin#1617
  * describe the need for module-name
    gh#PyO3/maturin#1604
  * Add PEP 517 config_settings support
    gh#PyO3/maturin#1619
  * Keep file mode on Unix
    gh#PyO3/maturin#1622
- Changes in v0.15.2:
  * Remove bors
    gh#PyO3/maturin#1602
  * When determining the python module name, use pyproject.toml
    project.name over Cargo.toml package.name.
    gh#PyO3/maturin#1608
  * Warn on missing python-source contents
    gh#PyO3/maturin#1607
  * Fix rewriting dev-dependencies in sdist
    gh#PyO3/maturin#1610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants