Add basic support for GraalPy #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
konstin
approved these changes
Jun 2, 2023
| @@ -9,6 +9,7 @@ use std::io::{BufRead, BufReader}; | |||
| use std::path::Path; | |||
|
|
|||
| const PYPY_ABI_TAG: &str = "pp73"; | |||
| const GRAALPY_ABI_TAG: &str = "graalpy230_310_native"; | |||
There was a problem hiding this comment.
what's the graalpy abi versioning policy? would be good to have that as a comment somewhere
Comment on lines
+24
to
+28
| # This should probably return the ABI tag based on EXT_SUFFIX in the same | ||
| # way as pypa/packaging. See https://github.com/pypa/packaging/pull/607. | ||
| # For simplicity, we just fix it up for GraalPy for now and leave the logic | ||
| # for the other interpreters untouched, but this should be fixed properly | ||
| # down the road. |
There was a problem hiding this comment.
i'd be happy to switch this over to what pypa/packaging does entirely, their logic is authoritative for all other tools anyway
messense
force-pushed
the
timfel/graalpy-support
branch
from
f33d3ad
to
0deb33a
Compare
messense
force-pushed
the
timfel/graalpy-support
branch
from
0deb33a
to
3bd154e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on making PyO3 support GraalPy in https://github.com/timfel/pyo3/tree/timfel/graalpy-support. To run the tests, I noticed I need maturin, so I had to make changes here as well. However, to run the maturin tests, I need the PyO3 changes.
Right now with this PR and my PyO3 branch, I can run the maturin tutorial example and a small number of PyO3 tests. Since the PyO3 changes will grow, whereas I expect the changes here to not be much more, I would like to open this for discussion.