Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --pip-path argument to develop #1753

Merged
merged 3 commits into from Sep 5, 2023

Conversation

mitsuhiko
Copy link
Contributor

This changes develop so that --pip-path can be passed to use a different pip. Example with rye:

maturin develop --pip-path ~/.rye/self/bin/pip

Fixes #1752

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 734ea83
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/64f1911df6cede000891f0bd
😎 Deploy Preview https://deploy-preview-1753--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@konstin
Copy link
Member

konstin commented Aug 30, 2023

One thing to check: maturin will pick up a folder called .venv even if VIRTUAL_ENV is not set (basically what PEP 704 used to propose). This works when running .venv/bin/pip, but if we run an external pip, will it pick up the right venv?

@mitsuhiko
Copy link
Contributor Author

@konstin if i understand the logic correctly the picking up of the venv happens and this is passed as --python, no?

@konstin
Copy link
Member

konstin commented Aug 31, 2023

yes, i expect this to work, but we should add an automated test to ensure it does, especially across platforms.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with accepting this as-is since most end users don't need to pass --pip-path.

@messense messense merged commit a608e3a into PyO3:main Sep 5, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maturin develop requires pip to be available
3 participants