Use external uniffi-bindgen if no root package is configured
#1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A "root package" in Cargo exists in a workspace if the workspace Cargo.toml also has a `[package]` section. In that case maturin tries to find a binary target called `uniffi-bindgen` to use. But if there's no root package to begin with it should fall back to an external `uniffi-bindgen` instead of panicking.
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 7, 2023
https://build.opensuse.org/request/show/1123696 by user mia + anag+factory - Update to 1.3.1 * Use external uniffi-bindgen if no root package is configured gh#PyO3/maturin#1797 * Add trusted publishing section to the user guide gh#PyO3/maturin#1800 * Fix wheel filename for GraalPy gh#PyO3/maturin#1802 * Pytest skeleton in mixed template gh#PyO3/maturin#1807 * Keep trailing newlines from templates gh#PyO3/maturin#1808 * Bump rustix from 0.37.23 to 0.37.25 gh#PyO3/maturin#1809 * Auto detect Python 3.13 gh#PyO3/maturin#1810 * Fix missing workspace.members in sdist gh#PyO3/maturin#1811 * Don't set MACOSX_DEPLOYMENT_TARGET for editable builds gh#PyO3/maturin#1815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "root package" in Cargo exists in a workspace if the workspace Cargo.toml also has a
[package]section.In that case maturin tries to find a binary target called
uniffi-bindgento use.But if there's no root package to begin with it should fall back to an external
uniffi-bindgeninstead of panicking.Fixes #1796
Note that this new behavior does not seem to be documented yet.
I'm not sure how common a root package is really.