Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new column fom_cost to all components with capital costs #411

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lisazeyen
Copy link
Contributor

@lisazeyen lisazeyen commented Jun 7, 2022

Closes #371 .

Changes proposed in this Pull Request

This PR should add an additional column to all components with capital costs. The capital costs are still including FOM + annualised investment costs. The information about the FOM fom_cost can be only used to calculated savings compared to the full capital costs in case of early retirement.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@lisazeyen lisazeyen requested a review from chrstphtrs June 7, 2022 15:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider writing "Fixed Operation and Maintenance costs" as description of fom_cost, at least to facilitate searches in the file and in the documentation.

The early retirement could also stem from a constraint on the max GHG emissions, in which case the savings not only stem from FOM costs decrease but also from VOM costs and fuel costs decrease.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment for generators.csv: please consider using the description "Fixed Operation and Maintenance costs" to be more explicit and facilitate searches for this parameter.

@Alex-Neve
Copy link

For each component CSV file, please consider using the description "Fixed Operation and Maintenance costs. Applies to an asset that is active, whether it is ON or OFF. Required to calculate total cost of electricity and enable decommissioning." to be more explicit and facilitate searches for this parameter.

The fixed O&M cost calculation should also be implemented downstream (spatial.py, linopf.py, opf.py, abstract.py, global_constraints.py, optimize.py, pf.py and statistics.py). Do you want to implement it?
If not I could try to create a separate PR to do it, following yours.

The doc/release_notes.rst should also be updated to indicate the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split capital cost into FOM and investment costs
2 participants