Add capacity additions and retirements to statistics #760
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coroa
changed the base branch from
fix-globalconstraints-primaryenergylimit
to
master
lisazeyen
reviewed
Oct 25, 2023
| df = pd.concat(per_period, axis=1) | ||
| elif when in ("build_year", "retirement") and groupby_kwargs is not None: | ||
| # TODO uses 9999 as the sentinel value for after modelling period | ||
| investment_periods = pd.Index(np.r_[n.investment_periods, 9999]) |
There was a problem hiding this comment.
maybe to make it clear just add one line
SENTINEL_YEAR = 9999
investment_periods = pd.Index(np.r_[n.investment_periods, SENTINEL_YEAR])
| period = investment_periods[0 if when == "build_year" else -1] | ||
| else: | ||
| year = n.df(c)["build_year"] | ||
| if when == "retirement": |
There was a problem hiding this comment.
we should add to the description that retirement is the first year the asset is not operating anymore
| if when == "retirement": | ||
| year += n.df(c)["lifetime"] | ||
|
|
||
| period = investment_periods[ |
There was a problem hiding this comment.
I haven't tested it but is it necessary to define the period or can we just groupby year?
| per_period[p] = df[n.get_active_assets(c, p).loc[df.index]] | ||
| df = pd.concat(per_period, axis=1) | ||
|
|
||
| if isinstance(n.snapshots, pd.MultiIndex): |
There was a problem hiding this comment.
maybe this functionality is also useful for running myopic code where you don't have a multi-index snapshot but still the information about build year and lifetime
|
Great! I only have some minor comments. I can't come up with better names, sorry! I think they one suggested are fine! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
whenargument to onlyoptimal_capacityadd the moment, which allows switching from selecting power plants, which are "active" in a given investment period to only show them at their "build_year" or at their "retirement" year.Not super happy with the names so fishing for suggestions and also comments on which other variables would benefit from such a scope.