Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of capex description #822

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Alex-Neve
Copy link

Closes PyPSA Issue #817.

Changes proposed in this Pull Request

Correction of the capex descriptions of the attributes CSV files.

Checklist

  • [ N/A ] Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • [ N/A ] Unit tests for new features were added (if applicable).
  • [ N/A ] Newly introduced dependencies are added to environment.yaml, environment_docs.yaml and setup.py (if applicable).
  • [ x ] A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • [ x ] I consent to the release of this PR's code under the MIT license.

@FabianHofmann
Copy link
Collaborator

@Alex-Neve there seem to be some unrelated changes in the .csv files. Could you have a look?

@Alex-Neve
Copy link
Author

@FabianHofmann Good catch! I see what happened: I edited my files in Microsoft Excel and it automatically changed a few details (adding a dot after 0 values, turning "False" into "FALSE", adding quotes around the text strings...).

I will commit new files directly edited in Notepad to avoid this sort of potential trouble.

Alex-Neve and others added 5 commits February 27, 2024 10:28
These CSV files fix the PyPSA issue PyPSA#817 with a corrected description for the capex attribute. These files versions are cleaned up from unrelated elements.
Fix description added for the next release.
Fix of the capital_cost parameter description for all 6 attributes CSV files. The changes unrelated for this fix were avoided by using the latest version of the main branch of PyPSA.
@Alex-Neve
Copy link
Author

I struggled a bit with some commits but the files look clean now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants