-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -one-file-system and -progress options to backup commands #78
base: master
Are you sure you want to change the base?
Conversation
Add features for excluding mounted filesystems from backups and for showing more progress during the backup process.
Hi John, Not sure about the whole impact, but after considering your PR I'm now thinking that maybe restricting everything to the current filesystem by default could be a better idea, not an option.
What do you think? Any downsides? |
If we made this the default restriction, would we provide an option to (As a minor note, it looks like for |
This parameter in the Duply conf file will be very easily manually removed. In the case of the CP and TAR used internally, I don't think we need an option to disable this parameter. Not sure, but cannot think of any case that can cause a possible conflict. |
Yeah, I think that makes sense to me. Would you like me to submit a new PR implementing this approach? |
Just for a better comprehension of this use case: Can you please explain why you need multiple filesystems in a folder that is publicly exposed (/var/www/example.com)? It caught my attention because you are using this option for cloning sites. |
Sure: we are currently using s3fs to mount our WordPress At this point this is a question of advice around server administration, but do you think this sort of strategy makes sense? |
Ok. It makes total sense!
Any comment/suggestion is welcome! |
These options were enabled for server backup, but site backups were overlooked, so this fixes that oversight.
This feature will be moved to the next major release v1.18.0. I've been thinking of a new approach, including an option in the Webinoly Configuration file to enable or disable the "One-File-System" globally. For example:
Any thoughts? |
We were finding that when doing backups, we wanted an option to skip folders that are mount points for other file systems. We also wanted to be able to get more feedback that the backup was progressing. The two options
-one-file-system
and-progress
meet these needs, respectively. We have implemented them here for both local and duply-mediated backups.