Skip to content

Commit

Permalink
Improve the performance of assemble when parameter_binds is a list of…
Browse files Browse the repository at this point in the history
… empty dicts (#8407)

* Fix the condition

* Update qiskit/compiler/assembler.py

* fix lint

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
  • Loading branch information
ikkoham and mergify[bot] committed Jul 28, 2022
1 parent 625ff98 commit 4fceb84
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions qiskit/compiler/assembler.py
Expand Up @@ -16,19 +16,18 @@
import uuid
import warnings
from time import time
from typing import Union, List, Dict, Optional
from typing import Dict, List, Optional, Union

import numpy as np

from qiskit.assembler import assemble_circuits, assemble_schedules
from qiskit.assembler.run_config import RunConfig
from qiskit.circuit import QuantumCircuit, Qubit, Parameter
from qiskit.circuit import Parameter, QuantumCircuit, Qubit
from qiskit.exceptions import QiskitError
from qiskit.providers.backend import Backend
from qiskit.pulse import LoConfig, Instruction
from qiskit.pulse import Schedule, ScheduleBlock
from qiskit.pulse import Instruction, LoConfig, Schedule, ScheduleBlock
from qiskit.pulse.channels import PulseChannel
from qiskit.qobj import QobjHeader, Qobj
from qiskit.qobj import Qobj, QobjHeader
from qiskit.qobj.utils import MeasLevel, MeasReturnType

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -569,7 +568,7 @@ def _expand_parameters(circuits, run_config):
"""
parameter_binds = run_config.parameter_binds

if parameter_binds or any(circuit.parameters for circuit in circuits):
if parameter_binds and any(parameter_binds) or any(circuit.parameters for circuit in circuits):

# Unroll params here in order to handle ParamVects
all_bind_parameters = [
Expand Down

0 comments on commit 4fceb84

Please sign in to comment.