Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump acorn from 7.1.0 to 7.1.1 #120

Merged
merged 1 commit into from Mar 19, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 14, 2020

Bumps acorn from 7.1.0 to 7.1.1.

Commits
  • 6d19489 Mark release 7.1.1
  • 793c0e5 More rigorously check surrogate pairs in regexp validator
  • b5c1787 Fix incorrect comment in regexp parser
  • 12ae8fe Parameterize dummy value and export isDummy
  • fa3ad8c Further refine acorn-walk types
  • 1d50286 Fix some errors in walk types
  • 97801f0 Mark acorn-walk 7.1.1
  • e9372c1 Further clean up walker types
  • de6edeb Remove NarrowNode from walk.d.ts
  • 1d85e7c Fix: acorn-walk type work with acorn's
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [acorn](https://github.com/acornjs/acorn) from 7.1.0 to 7.1.1.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@7.1.0...7.1.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 14, 2020
@KEINOS
Copy link
Member

KEINOS commented Mar 18, 2020

以下のデプロイ・プレビューで一通り動きを試して問題は見当たりませんでした。
LGTM なので今日の夜あたりにマージしちゃいますね。

@KEINOS
Copy link
Member

KEINOS commented Mar 18, 2020

別途、下記 minimist のセキュリティ・アラートも出てますが、この PR をマージしてから対応したいと思います。(minimist が何なのかわかってない)

"dependencies": {
-  "minimist": "0.0.8"
+  "minimist": ">=1.2.2"
}

スクリーンショット 2020-03-18 10 27 54

@yumetodo
Copy link
Contributor

yumetodo commented Mar 18, 2020

minimist の自動パッチはつくられないと見たほうがいいです。ESLintからきていると思うんですが、かなり依存が深くて自動では解決されないでしょう。現にここ数日私のGitrhubの通知欄はこれのせいで埋め尽くされています。
これはマージして、その後で自力で頑張って修正を試みるべきです。
image

@KEINOS
Copy link
Member

KEINOS commented Mar 19, 2020

minimist
かなり依存が深くて自動では解決されないでしょう。
これはマージして、その後で自力で頑張って修正を試みるべきです。

おっしゃる通り minimist の修正パッチは、やっぱち自動で作られまちぇんでちた。とりまーじります。

Minimist. Dependabot can not update to the required version.

Dependabot cannot create a pull request as one or more other dependencies require a version that is compatible with this update.

@KEINOS KEINOS merged commit 1df54f0 into master Mar 19, 2020
@KEINOS KEINOS deleted the dependabot/npm_and_yarn/acorn-7.1.1 branch March 19, 2020 02:18
@KEINOS
Copy link
Member

KEINOS commented Mar 19, 2020

F.Y.I.

なんか ESLint が使っている mkdirp パッケージが minimist に依存しているそうです。

ESLint 本家の Issueclose されてませんが、依存先の mkdirp は修正済みのようなので package-lock.json更新すれば直るらしい。

@yumetodo
Copy link
Contributor

yumetodo commented Mar 19, 2020

eslint v7系でmkdirpを使わなくなるので、
eslint/eslint#12753
それまで無視しませんか?自分の他のプロジェクトはそうしました。
ちなみにそれをbackportするPRは
eslint/eslint#13051
Rejectされました。backportなんて概念ないよってなんでや。

@KEINOS
Copy link
Member

KEINOS commented Mar 19, 2020

同じ HSA-7fhm-mqm4-2wp7 案件ですが、PR 内容が違うので minimist 対応について Issue を立てました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants