fix(deps-dev): #121 minimist 脆弱性対応 GHSA-7fhm-mqm4-2wp7 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.9.0 to 6.10.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v6.9.0...v6.10.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [acorn](https://github.com/acornjs/acorn) from 7.1.0 to 7.1.1. **This update includes a security fix.** - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@7.1.0...7.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 20.3.1 to 22.1.0. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v20.3.1...v22.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ava](https://github.com/avajs/ava) from 2.4.0 to 3.5.0. - [Release notes](https://github.com/avajs/ava/releases) - [Commits](avajs/ava@v2.4.0...v3.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) from 2.20.0 to 2.20.1. - [Release notes](https://github.com/benmosher/eslint-plugin-import/releases) - [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.20.0...v2.20.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
|
これ、ほんとにmkdirpの依存のminimistをメジャーアップデートして安全なんかなぁ・・・。 |
|
確かにアプデしたところで、 $ npm install
npm WARN deprecated mkdirp@0.5.3: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
...ただ、本家 ESLint 側でバックポートの PR がリジェクトされたのは、
以上から、とりあえずはアプデしておいていいのではないか、と。 やっぱり mkdirp を使わない ESLint v7 がいいとは思うので、とりまマージして、別途 ESLint v7-alpha を使っちゃうか、メジャー・リリースされたら、そっち（v7）に乗り換えるとかでいいんじゃないですかね。 ちなみに、この PR で
|
|
ああ、なるほど、この段階でmajorは上がってるのか、そして それなら大丈夫そうですね。 |
yumetodo
approved these changes
Mar 19, 2020
|
下記デプロイのプレビューで一連の動作確認しました。明日にでもマージしまーす。 Netlify べんりー |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
下記、本家の PR で言及されたように、パッケージとロックファイルをアップデートしただけです。