upgrade color-name dependency to ESM version #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmywarting
approved these changes
Dec 30, 2022
michaelfaith
approved these changes
Jun 4, 2023
Draft
|
#102 has been updated to include this now. So this change won't be necessary once that's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
color-namedependency was recently updated to use ESM, and released their packagev2.0.0with the only change being to use ESM default export. As a followup to #102, in the process of updating this package to ESM, we should also update our sole dependency to its ESM version.I have specifically omitted changing the import style in this PR, and updating the
package.jsonto"type": "module". As those changes have already been made in #102, and would be duplicative here.So -- just a fair warning -- the first round of tests will fail because of incorrect import style.
But once that #102 is merged, we can immediately pull
masterinto this branch. And at that time, it will pass tests.