Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let darken and lighten be the same as Scss function. #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let darken and lighten be the same as Scss function. #142

wants to merge 1 commit into from

Conversation

sammi
Copy link

@sammi sammi commented May 23, 2018

No description provided.

@Qix-
Copy link
Owner

Qix- commented Jun 12, 2018

  • Please fix tests.
  • Please explain what this PR is doing and why it was created.

Qix-
Qix- requested changes Jun 12, 2018
View reviewed changes
Copy link
Owner

@Qix- Qix- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@kwakwaversal
Copy link

This seems to be a rehash of #92 but missing changes to the lighten function from @ivansky's original submission.

I'm only here because internally we use the ivansky/color fork which implement these changes but is currently breaking npm due to depending on a git repo. Would much prefer to rely on the official repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qix- Qix- Qix- requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sammi @Qix- @kwakwaversal