Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCG color model manipulators #185

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

HCG color model manipulators #185

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 6, 2020

These manipulators for those, who will making dark and light themes, without color changes itself (doesn't change hue and chroma value). It useful for invert light into dark themes, and revert. Added 3 operators: lightenHcg, darkenHcg and negateHcg (now tinten, shaden, negateTones).

.light-theme {
  $mod: 0; /* dark font */
  color: hcg(240, 50, $mod);
}

.dark-theme {
  $mod: 100; /* light font */
  color: hcg(240, 50, $mod);
  filter: invert(100%) hue-rotate(180deg); /* same effect */ 
}

@Qix-
Copy link
Owner

Qix- commented Oct 20, 2020

Yeah the naming is exactly why I've not been accepting PRs for a long while. How to go about dealing with this problem is still a mystery to me.

The last thing I want is to dilute the API. Nobody is going to be able to read code and see "tintify" and know what it does.

I appreciate the PR and I'm sure it'll get accepted, just not right now. I still have to come up with a solution to this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant