-
Notifications
You must be signed in to change notification settings - Fork 44
Hypothesis + Array API blog post #252
Hypothesis + Array API blog post #252
Conversation
I'm quite happy with this now (would appreciate reviews of-course). The sheet is clear this month but note #251 might be scheduled for Sep 21. cc @melissawm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@honno I have very minor comments, otherwise this is looking really good. I like the pace and the progressive examples, they are motivating and clear. One thing I'd note is that it's not very clear at this point what exactly you worked on. You do say
Specifically I contributed "strategies" to the testing library Hypothesis, which I'm excited to announce is now available in hypothesis.extra.array_api.
But I think you could be a bit more specific or maybe link your PR to hypothesis here, to really showcase your hard work :)
Thank you Melissa for all your great feedback! Unfortunately I haven't quite got round to resolving everything, but I'll probably submit a "ready" draft tomorrow. I took Ralf's feedback in a call today to end the blog post in a more helpful manner—I ended up talking a bit about "comparison testing", so you could look at that now... I probably need to add an extra sentence there though, as well as finish the Fin section. My TODO seems to be:
|
I'm happy for another review. I changed the intro slightly (to give a tiny bit more context), and added a bit more to the end. |
8e0921d
to
e1097c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good, I have nothing else to note at this point :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had another read, it looks great, I don't even have minor comments on the text. @honno could you move the post and image to the 2021/10/
folder, and look at my two comments? Then let's get this published.
"nikola": { | ||
"author": "Matthew Barber", | ||
"date": "2021-09-17 00:00:00 UTC", | ||
"previewimage": "/images/2021/09/hypothesis-array-api-social.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you on purpose not use the image in the blog post itself? Could be nice to break up the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good shout. I put it at the start if that's okay (tested locally with a localhost link, but what I've pushed should work).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That didn't actually work, you need to use a relative link. Something like /images/2021/...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(check other posts for examples)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine? This won't work locally because the site preview uses the hardcoded labs.quansight.org link, not a dev environment friendly system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work locally because the site preview uses the hardcoded labs.quansight.org link, not a dev environment friendly system.
That's my point, it should work fine also with the dev env. All links should be /images/....
. All other posts do it like that, why can't this link be the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I was getting confused. So the meta:og
stuff hardcodes the link (so you can't preview social media images locally), but the post contents doesn't hardcode the link (I had just assumed it didn't heh). Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works for me too now!
Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
@rgommers Awesome, hope it's ready now. |
|
0f939c3
to
61898c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice post, thanks again @honno
Just found this - awesome post @honno! If you're still taking reviews...
|
Glad you like it @Zac-HD :) Yeah I'd like this post to be more of a reference than anything else, so updating the traceback and referencing your paper (handy!) are definitely good ideas. Will make a new PR at some point™ and ping you for additional review.
Haha that's intentional, thought it'd be interesting to mix in the official Array API (or rather Data APIs) colour scheme. Let me know if you'd prefer I keep with rainbow/blue Scout for this and other things going forward. |
Awesome, if it's a deliberate variation I love it! Ping me whenever Hypothesis feedback would be useful 😊 |
This article gives a brief demo of how one would use Hypothesis to test array-consuming methods. The structure and contents is pretty much finished, but this is still a draft and thus I would recommend a proper review take place once I remove the draft status. As well as going through the checks below, I will solicit feedback and generally mull it over before this happens.
This is part of the internship series of blog posts, but do note that it's purely technical. I'll leave personal musing out of this (and possibly write something for my own personal blog to link in this article), which I'd prefer anyway and gives breathing room for fellow interns to go more personal for their blog posts.
nbviewer, GitHub's preview
Text styling
Non-text contents
Me
Link personal blog post (if I write it)For every commit
nikola