-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(qwik-city): enforce / on base paths #6301
Conversation
Deploying qwik-docs with
|
Latest commit: |
71c9b6c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://70dfe784.qwik-8nx.pages.dev |
Branch Preview URL: | https://base-error.qwik-8nx.pages.dev |
I think we might need q:origin because I want the base path to be the same but different origin. and if I want to have a certain version of base then I'll change the base path to that version in ssr entry |
@PatrickJS could you elaborate on origin? I don't understand the use case |
so the base path might be the same but you may change the origin to an assets domain. in one of my apps we're using base to change the origin to an assets cdn while the app is hosted on another origin domain if I use base to change the origin then it will start with I think it's better to force base to only be the path and not the origin. and provide a better way to change the origin |
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@PatrickJS I think you can achieve it without q:origin. Set vite base to the URL prefix of the app and set the renderToStream base to the full url of the origin+prefix+build/ |
@mhevery not sure if this should go in only v2 because it might be slightly breaking.