Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Qwik GPT AI from the docs search #6314

Closed
wants to merge 2 commits into from
Closed

Conversation

thejackshelton
Copy link
Member

@thejackshelton thejackshelton commented May 15, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

We had a meeting regarding docs, and our consensus was that the Qwik GPT feature is not helpful in providing a good search experience to those looking to figure out how or why they should build with Qwik.

This PR tries to remove any lingering Qwik GPT code. While I'm sure some of us might get the feeling that we should comment it out and save it for later, I believe the reality is that would remain code in the codebase. We can always look in the file history and get it back if we really need it.

TODO: please review the packages/docs/src/routes/query/[id]/index.tsx file.

  • What is this file for?
  • What do we know is safe to remove?
  • What do you think we might not need?

Happy to continue this PR once those questions are answered 👍 . Would greatly appreciate the time taken to review this.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@thejackshelton thejackshelton marked this pull request as draft May 15, 2024 04:01
Copy link

netlify bot commented May 15, 2024

Deploy Preview for qwik-insights failed.

Name Link
🔨 Latest commit 65df1d4
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6644338a7df3770008dd3356

@PatrickJS
Copy link
Member

is this the same?
#6212 because we can reopen the old one

@thejackshelton
Copy link
Member Author

is this the same? #6212 because we can reopen the old one

Yep, it's a dupicate. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants