fix(optimizer): retain relative paths in extracted code #6326
+7,026
−25,311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for qwik-insights failed.
|
Deploying qwik-docs with
|
| Latest commit: |
a52d79e
|
| Status: | 🚫 Build failed. |
wmertens
force-pushed
the
hooks-relative-paths
branch
2 times, most recently
from
e9bda50
to
c412f9c
Compare
|
This fixes this issue right? |
wmertens
force-pushed
the
hooks-relative-paths
branch
3 times, most recently
from
4a2bd34
to
c3f2444
Compare
wmertens
force-pushed
the
hooks-relative-paths
branch
5 times, most recently
from
60a0b16
to
a8d3e57
Compare
wmertens
force-pushed
the
hooks-relative-paths
branch
from
a8d3e57
to
546e7f9
Compare
wmertens
force-pushed
the
hooks-relative-paths
branch
from
546e7f9
to
656c8b2
Compare
|
grr the small stuff is also going nowhere. Needs to be the big thing. Work in progress. I need to get dev mode working and then it looks like it will be very very nice |
PatrickJS
reviewed
May 28, 2024
wmertens
force-pushed
the
hooks-relative-paths
branch
from
656c8b2
to
3c540cb
Compare
this fixes imports-of-imports and is also nicer for debugging
wmertens
force-pushed
the
hooks-relative-paths
branch
3 times, most recently
from
cced13c
to
e905d33
Compare
+ remove import-of-import workaround Transforming breaks other vite plugins, slows down dev start and might transform more than needed
The bundler should handle entries. Prefetching can still indicate the full graph to fetch and http2 makes that fast.
Now the bundler can decide which QRLs to host toghether. - chunk URLs now can include the exported attr as `chunk#attr` - manifest generation is now more robust - refactored manifest generation
needs to support the absolute path and ?qrl= query
- support vite base - build qrls on demand
wmertens
force-pushed
the
hooks-relative-paths
branch
from
e905d33
to
bce7eed
Compare
PatrickJS
reviewed
Jun 3, 2024
| @@ -102,10 +102,12 @@ export const qwikLoader = ( | |||
| for (const qrl of attrValue.split('\n')) { | |||
| const url = new URL(qrl, base); | |||
| const href = url.href; | |||
| const symbol = url.hash[replace](/^#?([^?[|]*).*$/, '$1') || 'default'; | |||
| const match = /^#?(([^#]+)#)?([^?[|]*).*$/.exec(url.hash); | |||
There was a problem hiding this comment.
can we add regexp online editor link. for example https://regexr.com/ lets you also add regexp tests for example https://regexr.com/816es (don't use mine we should make a qwik account with all them saved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes imports-of-imports (#5473) properly and has some other small fixes
I had a bigger PR that also removed prebuilding and entries but I am running into trouble with it, so I'm first merging the small stuff.