fix: a bug #6330
fix: a bug #6330
Conversation
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
| @@ -144,7 +144,7 @@ function recursiveScan( | |||
| } | |||
| let pathIdx = pathLength; | |||
| const sep = suffix + '/'; | |||
| let depthWatchdog = 5; | |||
| let depthWatchdog = 8; | |||
There was a problem hiding this comment.
I think you can set this to 50 and also add a console.error before line 160 when it gets to 0
There was a problem hiding this comment.
what do you think about the thrown exception?
There was a problem hiding this comment.
we merged #6327 which remove the limit and adds a test. do we want a limit?
There was a problem hiding this comment.
So do I close this pr?
There was a problem hiding this comment.
I wanted to get his pr in since he was first-time contributor 😁 I think we should have a limit of 50 or some way to set a limit. I don't think any app will even reach 50
There was a problem hiding this comment.
@PatrickJS still needs this limit？So do i continue this PR ?
There was a problem hiding this comment.
@JerryWu1234 I'll close the PR I know you're working on a few other things 🙏 thanks so much for helping us
|
this is the same as #6327 |
Overview
#6300
What is it?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why
Checklist: