WIP - custom knit: handle xaringan::inf_mr #875

ElianHugh · 2021-11-22T03:40:26Z

What problem did you solve?

Solves #796.

Both knitting and previewing xaringan slides should work as expected

(If you do not have screenshot) How can I check this pull request?

Knitting the following should work (i.e., progress bar signals completion), and closing the webview should dispose of the process.

---
title: "Test"
knit: xaringan::inf_mr
output:
  xaringan::moon_reader:
    lib_dir: libs
    nature:
      highlightStyle: github
      highlightLines: true
      countIncrementalSlides: false
---

class: center, middle

# Test

### 1234

Use an enum to restrict the input for the setting: r.rmarkdown.codeLensCommands

Now stops the child process when the webview is closed

ElianHugh · 2021-12-02T04:56:34Z

i'm a little iffy on how broad the url regex should be, because i don't want it to trigger on just any url that might pop up in the output stream

* Rename liveshare folder to liveShare * Rename folder

* Implement mutation observer Observe changes in the DOM, in order to ensure urls are appropriate for webview restrictions * pre -> span, clean up observer method * Refactor webview * Refactor html into func, observe content only * Improve docs, change URL testing * Minor update * Simplify regex usage - Remove superfluous console.log - Simplify regex usage * (Misc) change directory - Change webview/observer.js to session/webview/observer.js * Fix merge conflict * Broaden regex, bug fix - Fix slowdown for DOMs that have many updates a second - Fix more resource request paths * Only test specific tags - No need to test tags that do not typically have src values. This can be expanded if a tag is missing from the list * Debounce mut. observer Co-authored-by: Kun Ren <renkun@outlook.com>

* PoF accessing VSC settings ** proof of concept ** Load R-related vsc settings and set as R option * Update getSettings.R * Fiddle with configurations * Setup example usage * Write settings.json to .vscode-R folder * Source vscode settings first * Move import back to init, only replace ops if null * Update package.json * Descriptive names, move settings under categories * Change setting names * Load settings before attach * Refine load_settings * Fix * Update viewColumn setting Update the viewColumn item's description * Minor typos * Use expression mapping * Use quote list Co-authored-by: Kun Ren <renkun@outlook.com> Co-authored-by: Manuel Hentschel <53863351+ManuelHentschel@users.noreply.github.com>

* Fixes REditorSupport#713 Uses the match pattern for functions from the textmate R grammar * Remove old rbox message

* Handle error in capture_str * Simplify capture_str

* Add icons to webviews * Use class for icon sourcing - Use the UriIcon constructor to create icon uris * Remove unused icon - Removes the search.svg icon, as open-preview.svg was used instead

* background knitting (with progress bar) * set knit working directory * Smart knit button, use custom knit functions + rmarkdown::render_site where appropriate

- Contributes a helper function for creating disposables from objects - Simplifies disposal of child processes - Do not print lines to output when the process has already been terminated - use childProcess.spawn instead of childProcess.exec, to allow for faster process termination

* Add object length limit * Update inspect_env * Preserve the order of names in completion

* Move R-related session files to `R/session` * Move `getAliases.R` to `R/help` * New file `helpServer.R` in `R/help` * New file `knit.R` in `R/rmarkdown` * New file `preview.R` in `R/rmarkdown`

Fixes regression with REditorSupport#781 due to a typo in requireNamespace

* Respect output format * Fix anchor tags

Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/fb55/nth-check/releases) - [Commits](fb55/nth-check@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: nth-check dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update vsc.R * Modify url to allow proxied requests * Minor update * Fix message for webview Co-authored-by: Kun Ren <renkun@outlook.com>

* Respect cwd * Start knit process from knitWorkingDirectory * Refine getKnitDir Co-authored-by: Kun Ren <renkun@outlook.com>

…rSupport#816)

* browser handles file:// * No need to check before sub

…Support#815) * Add r.session.levelOfObjectDetail=Normal for max.level=1 * Add object timeout * Update capture_str

…rt#827)

* Add R info to status bar item text and tooltip * Remove attach_time and add command * Update shareSession.ts

* get knit command from settings * configuration option description * Refine description * Use a default value * Update comment Co-authored-by: Kun Ren <renkun@outlook.com>

* Fix package installation * Fix typo Co-authored-by: Kun Ren <renkun@outlook.com>

* Add support for indented Roxygen * Exit roxygen after 2 empty lines * Fix regex

…ditorSupport#859) * Add backtick to list of quote characters for syntax highlighting. * backticks denote nonstandard variable names and should therefore be coloured like variables

* Fix detecting yaml frontmatter * Simplify condition

* Auto refresh help * Use installed.packages to handle package updates * Only write log when restarting help server Co-authored-by: Kun Ren <renkun@outlook.com>

Now stops the child process when the webview is closed

…o rmd-fixes

ElianHugh and others added 5 commits July 15, 2021 18:07

Update r.rmarkdown.codeLensCommands

f1eef75

Use an enum to restrict the input for the setting: r.rmarkdown.codeLensCommands

Merge branch 'master' of https://github.com/ElianHugh/vscode-R

9c32315

Initial handling of xarningan::inf_mr

ed2d16e

Kill the child process!

814481c

Now stops the child process when the webview is closed

Allow localhost

8a7a043

renkun-ken and others added 24 commits May 12, 2022 16:29

Check conflict extension (REditorSupport#733)

7f1c920

Fix date filter in data viewer (REditorSupport#736)

294c473

Rename liveshare folder to liveShare (REditorSupport#738)

e76bea2

* Rename liveshare folder to liveShare * Rename folder

Fix README

829149b

Use .DollarNames with default pattern (REditorSupport#750)

6978d5b

Fix issues with c() in function args (REditorSupport#751)

b5a38fe

* Fixes REditorSupport#713 Uses the match pattern for functions from the textmate R grammar * Remove old rbox message

Handle error in capture_str (REditorSupport#756)

df4606c

* Handle error in capture_str * Simplify capture_str

Add icons to webviews (REditorSupport#759)

6f001c1

* Add icons to webviews * Use class for icon sourcing - Use the UriIcon constructor to create icon uris * Remove unused icon - Removes the search.svg icon, as open-preview.svg was used instead

release 2.2.0

31cd9df

Enable rstudioapi by default (REditorSupport#769)

d830666

Use unsafe-inline for script-src (REditorSupport#771)

8da3923

R Markdown Enhancements (Knit Manager) (REditorSupport#765)

a374935

* background knitting (with progress bar) * set knit working directory * Smart knit button, use custom knit functions + rmarkdown::render_site where appropriate

Add object length limit (REditorSupport#778)

3e0619c

* Add object length limit * Update inspect_env * Preserve the order of names in completion

Write NA as string (REditorSupport#780)

911249f

Use R files for background process (REditorSupport#783)

81cf926

* Move R-related session files to `R/session` * Move `getAliases.R` to `R/help` * New file `helpServer.R` in `R/help` * New file `knit.R` in `R/rmarkdown` * New file `preview.R` in `R/rmarkdown`

Fix RMD requireNamespace (REditorSupport#784)

b5cdbaf

Fixes regression with REditorSupport#781 due to a typo in requireNamespace

Respect preview output format (REditorSupport#785)

6332328

* Respect output format * Fix anchor tags

Bump @types/vscode from 1.57.0 to 1.60.0 (REditorSupport#786)

0777aa3

Extend providers to rmd (REditorSupport#787)

baeb5fd

Update vscode and ag-grid version

f2b8d04

renkun-ken and others added 30 commits May 12, 2022 16:29

release 2.3.0

48fe454

Update vsc.R (REditorSupport#803)

ce40e74

* Update vsc.R * Modify url to allow proxied requests * Minor update * Fix message for webview Co-authored-by: Kun Ren <renkun@outlook.com>

Reenable 'unsafe-eval' in script-src CSP (REditorSupport#805)

d6d7a6b

Use r.session.viewers.viewColumn.helpPanel (REditorSupport#804)

e4e7b44

Use cwd in knit process (REditorSupport#807)

99af536

* Respect cwd * Start knit process from knitWorkingDirectory * Refine getKnitDir Co-authored-by: Kun Ren <renkun@outlook.com>

Bump version

31b7673

release 2.3.1

8c8c7d5

Httpgd plot viewer respects r.session.viewers.viewColumn.plot (REdito…

9c149a9

…rSupport#816)

Completely replace View (REditorSupport#818)

98f8dca

Change help cache default (REditorSupport#819)

b7c3058

browser handles file:// (REditorSupport#817)

1b7a569

* browser handles file:// * No need to check before sub

Add r.session.levelOfObjectDetail=Normal for max.level=1 (REditor…

29801b7

…Support#815) * Add r.session.levelOfObjectDetail=Normal for max.level=1 * Add object timeout * Update capture_str

Update address

155bb15

Check workspace folder with both original and real path (REditorSuppo…

cbeda76

…rt#827)

release 2.3.2

9092f8f

Add R info to status bar item text and tooltip (REditorSupport#836)

1e400e0

* Add R info to status bar item text and tooltip * Remove attach_time and add command * Update shareSession.ts

get knit command from settings (REditorSupport#841)

b360d88

* get knit command from settings * configuration option description * Refine description * Use a default value * Update comment Co-authored-by: Kun Ren <renkun@outlook.com>

Fix package installation (REditorSupport#846)

12f3b20

* Fix package installation * Fix typo Co-authored-by: Kun Ren <renkun@outlook.com>

Add support for indented Roxygen (REditorSupport#847)

2af23c4

* Add support for indented Roxygen * Exit roxygen after 2 empty lines * Fix regex

Syntax highlighting for indented roxygen (REditorSupport#850)

e469a97

Use new terminal API (REditorSupport#851)

9947208

Add backtick to list of quote characters for syntax highlighting. (RE…

1706790

…ditorSupport#859) * Add backtick to list of quote characters for syntax highlighting. * backticks denote nonstandard variable names and should therefore be coloured like variables

Fix detecting yaml frontmatter (REditorSupport#856)

130f95c

* Fix detecting yaml frontmatter * Simplify condition

Auto refresh help (REditorSupport#863)

c15a9ef

* Auto refresh help * Use installed.packages to handle package updates * Only write log when restarting help server Co-authored-by: Kun Ren <renkun@outlook.com>

Handle plot on attach (REditorSupport#852)

0845351

Initial handling of xarningan::inf_mr

49806ec

Kill the child process!

60da38a

Now stops the child process when the webview is closed

Allow localhost

4ebe16a

Force file to be self contained

da0b18b

Merge branch 'rmd-fixes' of https://github.com/ElianHugh/vscode-R int…

a5b5e45

…o rmd-fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP - custom knit: handle xaringan::inf_mr #875

WIP - custom knit: handle xaringan::inf_mr #875

ElianHugh commented Nov 22, 2021 •

edited

ElianHugh commented Dec 2, 2021

WIP - custom knit: handle xaringan::inf_mr #875

Are you sure you want to change the base?

WIP - custom knit: handle xaringan::inf_mr #875

Conversation

ElianHugh commented Nov 22, 2021 • edited

What problem did you solve?

(If you do not have screenshot) How can I check this pull request?

ElianHugh commented Dec 2, 2021

ElianHugh commented Nov 22, 2021 •

edited