Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some UI issues related to dark mode #165

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

diegodiome
Copy link

 theme based on system settings, and persistent theme state across app
 restarts. Also fixed alignment issue with a button.
@theperu
Copy link
Collaborator

theperu commented Apr 13, 2024

Hi! I noticed that the planning page looks a bit strange and I cannot see what I am doing when I manage them. Also in the transaction page there are some text in dark blue that I think are quite hard to read, maybe we could switch them to the same grey that we use for "Add a description".
Apart from these two things I think it looks good, thanks!

Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you solved most of the issues, unfortunately now the onboarding doesn't look great if you open the app and you have the dark mode set as default. If it's not an easy fix maybe we could ignore the theme for the onboarding and check it only after it.
Also in the planning page when I tap on manage in the top right the modal looks a bit off and I cannot read the texts for each budget set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants