Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bool parsing and add sequence serialization #48

Conversation

MarcAntoine-Arnaud
Copy link

No description provided.

@oli-obk
Copy link
Collaborator

oli-obk commented Sep 11, 2017

Sorry, we won't support this. Use serde(deserialize_with) instead. Reasoning: #18 (comment)

@oli-obk oli-obk closed this Sep 11, 2017
@farodin91
Copy link
Contributor

Also dublicated sequence serialization see #36

@MarcAntoine-Arnaud
Copy link
Author

Regarding Boolean, the W3C standard mention ·boolean· can have the following legal literals {true, false, 1, 0}.
This is why it can made sense to add it in this library.

@oli-obk
Copy link
Collaborator

oli-obk commented Sep 11, 2017

@RReverser opinions?

@RReverser
Copy link
Owner

3.2.2.1 Lexical representation
An instance of a datatype that is defined as ·boolean· can have the
following legal literals {true, false, 1, 0}.

3.2.2.2 Canonical representation
The canonical representation for boolean is the set of
literals {true, false}.

This is interesting indeed. If that's called a canonical representation by spec, I agree it's a game changer and makes sense to support it by default (assuming we are still able to have helper functions for 0 / 1 and "exists" / "doesn't exist" representations).

@oli-obk oli-obk reopened this Sep 11, 2017
@RReverser
Copy link
Owner

@MarcAntoine-Arnaud Could you please split your commits into two PRs so that we don't mix discussions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants