Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphics for S60/P & TS101 #1819

Closed
wants to merge 50 commits into from
Closed

Conversation

discip
Copy link
Collaborator

@discip discip commented Sep 22, 2023

@Ralim
Here you go. 😀

Tried to implement all the necessary graphics for S60/P & TS101.

I know this will not work until you do all the necessities around it.
At least I hope the way I tried to implement this makes any sense. 😅

Not every graphic is pretty yet, but at least it should be testable.

Please let me know what you think.

menu animations
power Power
soldering Soldering
sleep Sleep
UI UI
advanced Advanced
statics
S60/P TS101
A-button A-button A-button
B-button B-button
missing tip missing tip missing tip
unavailable unavailable
bootlogo once once
loop loop

@discip discip changed the title Graphics for s60/p & ts101 graphics for s60/p & ts101 Sep 22, 2023
@discip discip changed the title graphics for s60/p & ts101 graphics for S60/P & TS101 Sep 22, 2023
@discip
Copy link
Collaborator Author

discip commented Sep 23, 2023

@Ralim
Don't know if you had a chance to observe the changed pics.
I assume: Most likely not ! 😀
Anyway now there are attached gifs ...

Hope you like it.

@Ralim
Copy link
Owner

Ralim commented Sep 24, 2023

Amazing work, suppppppppeeerrrr appreciate it.

Haven't had a chance to test on hardware yet but when I get some downtime I will do some quick patching to get some of this in place asap 🤞

Thank you so much for this ❤️

@discip discip marked this pull request as draft February 10, 2024 17:46
auto-merge was automatically disabled February 10, 2024 17:46

Pull request was converted to draft

@brushmate
Copy link

I somehow managed to compile your branch for my TS101 by rebasing your branch on the dev branch, but the icons are not being displayed correctly. I guess this is because support for bigger displays has not been added yet?

IMG_20240211_210201

@Jonny-T-cyber
Copy link

Hi!
I'm waiting for the firmware for the TS101 to be completed so I can install it, in the meantime...
where can I find the ORIGINAL firmware for the TS101 so I can go back in case of problems?
Thanks

@discip
Copy link
Collaborator Author

discip commented Feb 12, 2024

@brushmate

I somehow managed to compile your branch for my TS101 by rebasing your branch on the dev branch, but the icons are not being displayed correctly. I guess this is because support for bigger displays has not been added yet?

As you may have noticed in your photo only a portion of the OLED but the individual graphics are intended for the whole screen.
So we have to wait until the support for the entire OLED gets implemented.

@Jonny-T-cyber
Copy link

Jonny-T-cyber commented Feb 12, 2024

On my new TS101 I have firmware V2.04.
While in the link you provided the latest version is V2.01 (which I had already found online).
Has anyone found a link to version V2.04?
Thanks

@ArturoGuerra
Copy link
Contributor

Besides the graphics what else is needed? @Ralim

@Ralim
Copy link
Owner

Ralim commented Feb 28, 2024

This will be pulled in via the branch for splitting out rendering for different screen sizes. I'm slowly working on it as life allows me to.

@ArturoGuerra
Copy link
Contributor

This will be pulled in via the branch for splitting out rendering for different screen sizes. I'm slowly working on it as life allows me to.

okay I'll have a look in a bit and see if I can help with that, also for the standardized power interface do you want to include all currently supported usb protocols so QC and USB-PD or just USB-PD?

@Ralim
Copy link
Owner

Ralim commented Feb 28, 2024

Once I finish splitting all the render/* functions out (in a day or two) I'll start a draft PR to track it.
When that happens then basically need to update every single render function to layout on the larger screen correctly 😓

I only intend to implement PD for all devices going forward if I get any choice in it. QC is a dead standard and its a shit-show for compatibility as well. Much prefer only focusing on standards that are open and properly standardised.

@discip
Copy link
Collaborator Author

discip commented Mar 13, 2024

@Ralim
Any news so far? 😊

Ralim added a commit that referenced this pull request Mar 20, 2024
@Ralim
Copy link
Owner

Ralim commented Mar 20, 2024

Any news so far? 😊

I've now pulled these into #1883, and will slowly be working over there to update all the drawing commands to draw the right size / location

@discip
Copy link
Collaborator Author

discip commented Apr 3, 2024

@Ralim
Hey Ben,
thank you for keeping this going. 😃👍

Could you please help finding the cause, why this doesn't compile for the S60P, but for the TS101 it does?

thanks in advance

@ia
Copy link
Collaborator

ia commented Apr 3, 2024

Could you please help finding the cause, why this doesn't compile for the S60P, but for the TS101 it does?

Hello.

It seems there is no declaration of ButtonA and related stuff in Font.h for S60P model explicitly. What's going on in Font.h is pure magic for me (I mean those constants), but apparently between all of these #ifdef MODEL / #else / #endif there is a missing conditional branch for macro pre-processor managing values of ButtonA and disconnectedTip.

Pre-processor goes here for S60P first, but then there is conditions like:
#ifdef MODEL_S60
and
#elif defined MODEL_TS101
but there is no values of the variables for S60P, because there is no such condition for S60P to define related values.

Basically, since support for S60P has been implemented, now Font.h should be updated and ported to support for S60P.

Probably for fix you should make this line to look something like this:
#if defined(MODEL_S60) || defined(MODEL_S60P)
but I'm not 100% sure that the values from S60 variables will be valid for S60P model.

Hope it will help.

@discip
Copy link
Collaborator Author

discip commented Apr 3, 2024

Thank you very much for the effort you put into describing the issue so precisely!

#if defined(MODEL_S60) || defined(MODEL_S60P)

You are absolutely right. That's the line I missed. 🤦‍♂️

@ia
Copy link
Collaborator

ia commented Apr 3, 2024

Thank you very much for the effort you put into describing the issue so precisely!

#if defined(MODEL_S60) || defined(MODEL_S60P)

You are absolutely right. That's the line I missed. 🤦‍♂️

I just was happy to help with everything I can, as always. Glad it worked. :)

@discip
Copy link
Collaborator Author

discip commented Apr 9, 2024

This was implemented in #1888.

@discip discip closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants