Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dtype=object when creating Ragged array #12092

Merged
merged 13 commits into from Mar 6, 2023

Conversation

d61h6k4
Copy link
Contributor

@d61h6k4 d61h6k4 commented Feb 28, 2023

To create an array from a list of inhomogeneous objects, explicitly set the type to object

Since NumPy 1.24 numpy raises ValueError when creating a Ragged array numpy/numpy#22004

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

In order to create an array from list of inhomogeneus objects explicitly
dtype to object

Since numpy 1.24 numpy raises ValueError when creating Ragged array
numpy/numpy#22004
@d61h6k4 d61h6k4 requested a review from a team as a code owner February 28, 2023 10:25
@d61h6k4 d61h6k4 requested review from ancalita and Shmuma March 3, 2023 13:22
poetry.lock Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
rasa/utils/tensorflow/model_data.py Outdated Show resolved Hide resolved
rasa/utils/tensorflow/model_data.py Outdated Show resolved Hide resolved
@d61h6k4 d61h6k4 requested a review from ancalita March 6, 2023 11:17
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

rasa/utils/tensorflow/model_data.py Outdated Show resolved Hide resolved
Co-authored-by: Anca Lita <27920906+ancalita@users.noreply.github.com>
@varunshankar varunshankar self-requested a review March 6, 2023 11:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

🚀 A preview of the docs have been deployed at the following URL: https://12092--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@d61h6k4 d61h6k4 enabled auto-merge (squash) March 6, 2023 13:24
@d61h6k4 d61h6k4 merged commit 0dddbdb into main Mar 6, 2023
@d61h6k4 d61h6k4 deleted the ENG-45-numpy-deprecation-issue branch March 6, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants