Add support for decoding WebP images #747
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. All we have to do now is to ask them nicely to stop using |
|
Looks like we need a MSRV bump as well. |
|
Ok, waiting for 0.1.3 and I'm ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya 馃憢
I was hoping to use WebP in a project, and noticed (via #575) that the
image-webpproject has been published now. This PR adds support for the project withinresvg.As noted in #575 there may be performance issues - I haven't tested extensively. However in my use case, it saves a step of converting
.webpimages to a compatible format, so even a slow(ish) implementation is an overall positive. With that in mind, it feels like a step forward forresvgto support WebP, even if there's still room in future for their (pre-1.0) project to improve.