Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add best-effort support for COLRv1 #758

Merged
merged 6 commits into from
May 13, 2024
Merged

Conversation

LaurenzV
Copy link
Contributor

No description provided.

@RazrFalcon
Copy link
Owner

Ready to merge?

@LaurenzV
Copy link
Contributor Author

Ready to merge?

Yep.

@RazrFalcon RazrFalcon merged commit 4b4e897 into RazrFalcon:master May 13, 2024
3 checks passed
@RazrFalcon
Copy link
Owner

I plan to make a resvg release soon. Do you have any more changes planned?
PS: for some reason I've thought we have already release the color fonts support...

@LaurenzV
Copy link
Contributor Author

I plan to make a resvg release soon. Do you have any more changes planned?

Well, ideally it would've been nice to figure out the font selection problem (#754) before the next release, but it it looks like it will still take some time and I think @laurmaedje is currently busy with other stuff right now, so I guess there is nothing holding us off from making a new release right now.

@LaurenzV LaurenzV deleted the colrv1 branch May 13, 2024 12:06
@RazrFalcon
Copy link
Owner

Ok, I will take a look at #754 myself this week and if it would not work will release resvg as is.

@LaurenzV
Copy link
Contributor Author

Thanks, but I'm not sure how much you can help in this case, since we need to test the integration into Typst ourselves... If I have time in the evening I will try again myself.

@RazrFalcon
Copy link
Owner

I understand. I just want to try different approaches. I don't plan to merge them immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants