Skip to content

Add wasmJs support #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Add wasmJs support #45

merged 4 commits into from
Jan 4, 2024

Conversation

luca992
Copy link
Contributor

@luca992 luca992 commented Jan 2, 2024

No description provided.

@luca992 luca992 requested a review from ychescale9 as a code owner January 2, 2024 08:09
Copy link
Member

@ychescale9 ychescale9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! are we able to move the dependency updates to a separate PR?

@luca992
Copy link
Contributor Author

luca992 commented Jan 3, 2024

A few are needed, like coroutines. But I can revert anything strictly not needed if that works?

If you don't want to merge a release candidate dependency, I understand. But it'd be cool if you could make a separate branch and put out a snapshot in the meantime if possible

@ychescale9
Copy link
Member

Sure. I don't mind merging coroutines RC as I'm not planning to publish a new release soon.

@luca992
Copy link
Contributor Author

luca992 commented Jan 4, 2024

@ychescale9 coroutines and atomicfu had to be updated to support wasmJs. I reverted the rest and made another pr

@ychescale9 ychescale9 merged commit c3b99c9 into ReactiveCircus:main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants