Skip to content

Commit

Permalink
Merge pull request #20 from naghtarr/naghtarr/itemclicks
Browse files Browse the repository at this point in the history
Add OperatorAdapterViewOnItemClick to observe OnItemClick events in AdapterViews. Resolve #19.
  • Loading branch information
mttkay committed Oct 15, 2014
2 parents 2bb5640 + db454db commit ddbd8d7
Show file tree
Hide file tree
Showing 6 changed files with 559 additions and 15 deletions.
19 changes: 19 additions & 0 deletions src/main/java/rx/android/events/OnItemClickEvent.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package rx.android.events;

import android.view.View;
import android.widget.Adapter;
import android.widget.AdapterView;

public class OnItemClickEvent {
public final AdapterView<?> parent;
public final View view;
public final int position;
public final long id;

public OnItemClickEvent(AdapterView<?> parent, View view, int position, long id) {
this.parent = parent;
this.view = view;
this.position = position;
this.id = id;
}
}
20 changes: 10 additions & 10 deletions src/main/java/rx/android/observables/AndroidObservable.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,23 +15,23 @@
*/
package rx.android.observables;

import static rx.android.schedulers.AndroidSchedulers.mainThread;

import android.content.SharedPreferences;
import rx.Observable;
import rx.functions.Func1;
import rx.android.operators.OperatorBroadcastRegister;
import rx.android.operators.OperatorConditionalBinding;
import rx.android.operators.OperatorLocalBroadcastRegister;

import android.app.Activity;
import android.app.Fragment;
import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.content.SharedPreferences;
import android.os.Build;
import android.os.Handler;
import rx.operators.OperatorSharedPreferenceChange;

import rx.Observable;
import rx.android.operators.OperatorBroadcastRegister;
import rx.android.operators.OperatorConditionalBinding;
import rx.android.operators.OperatorLocalBroadcastRegister;
import rx.android.operators.OperatorSharedPreferenceChange;
import rx.functions.Func1;

import static rx.android.schedulers.AndroidSchedulers.mainThread;


public final class AndroidObservable {
Expand Down
15 changes: 11 additions & 4 deletions src/main/java/rx/android/observables/ViewObservable.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,21 @@
*/
package rx.android.observables;

import android.view.View;
import android.widget.AdapterView;
import android.widget.CompoundButton;
import android.widget.TextView;

import rx.Observable;
import rx.android.events.OnCheckedChangeEvent;
import rx.android.events.OnClickEvent;
import rx.android.events.OnItemClickEvent;
import rx.android.events.OnTextChangeEvent;
import rx.android.operators.OperatorAdapterViewOnItemClick;
import rx.android.operators.OperatorCompoundButtonInput;
import rx.android.operators.OperatorTextViewInput;
import rx.android.operators.OperatorViewClick;

import android.view.View;
import android.widget.CompoundButton;
import android.widget.TextView;

public class ViewObservable {

public static Observable<OnClickEvent> clicks(final View view) {
Expand All @@ -53,4 +56,8 @@ public static Observable<OnCheckedChangeEvent> input(final CompoundButton button
return Observable.create(new OperatorCompoundButtonInput(button, emitInitialValue));
}

public static Observable<OnItemClickEvent> itemClicks(final AdapterView<?> adapterView) {
return Observable.create(new OperatorAdapterViewOnItemClick(adapterView));
}

}
103 changes: 103 additions & 0 deletions src/main/java/rx/android/operators/OperatorAdapterViewOnItemClick.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
/**
* Copyright 2014 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package rx.android.operators;

import android.view.View;
import android.widget.AbsListView;
import android.widget.AdapterView;

import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.WeakHashMap;

import rx.Observable;
import rx.Subscriber;
import rx.Subscription;
import rx.android.events.OnItemClickEvent;
import rx.android.observables.Assertions;
import rx.android.subscriptions.AndroidSubscriptions;
import rx.functions.Action0;

public class OperatorAdapterViewOnItemClick implements Observable.OnSubscribe<OnItemClickEvent> {

private final AdapterView<?> adapterView;

public OperatorAdapterViewOnItemClick(final AdapterView<?> adapterView) {
this.adapterView = adapterView;
}

@Override
public void call(final Subscriber<? super OnItemClickEvent> observer) {
Assertions.assertUiThread();
final CompositeOnClickListener composite = CachedListeners.getFromViewOrCreate(adapterView);

final AbsListView.OnItemClickListener listener = new AdapterView.OnItemClickListener() {
@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
observer.onNext(new OnItemClickEvent(parent, view, position, id));
}
};

final Subscription subscription = AndroidSubscriptions.unsubscribeInUiThread(new Action0() {
@Override
public void call() {
composite.removeOnClickListener(listener);
}
});

composite.addOnClickListener(listener);
observer.add(subscription);
}

private static class CompositeOnClickListener implements AbsListView.OnItemClickListener {
private final List<AbsListView.OnItemClickListener> listeners = new ArrayList<AbsListView.OnItemClickListener>();

public boolean addOnClickListener(final AbsListView.OnItemClickListener listener) {
return listeners.add(listener);
}

public boolean removeOnClickListener(final AbsListView.OnItemClickListener listener) {
return listeners.remove(listener);
}

@Override
public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
for (AdapterView.OnItemClickListener listener : listeners) {
listener.onItemClick(parent, view, position, id);
}
}
}

private static class CachedListeners {
private static final Map<AdapterView<?>, CompositeOnClickListener> sCachedListeners = new WeakHashMap<AdapterView<?>, CompositeOnClickListener>();

public static CompositeOnClickListener getFromViewOrCreate(final AdapterView<?> view) {
final CompositeOnClickListener cached = sCachedListeners.get(view);

if (cached != null) {
return cached;
}

final CompositeOnClickListener listener = new CompositeOnClickListener();

sCachedListeners.put(view, listener);
view.setOnItemClickListener(listener);

return listener;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package rx.operators;
package rx.android.operators;

import android.content.SharedPreferences;
import rx.Observable;
Expand Down

0 comments on commit ddbd8d7

Please sign in to comment.