1.x: fix ReplaySubject anomaly around caughtUp by removing that optimization #4051
+99
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 80.49%@@ 1.x #4051 diff @@
==========================================
Files 253 253
Lines 16478 16469 -9
Methods 0 0
Messages 0 0
Branches 2500 2491 -9
==========================================
+ Hits 13244 13256 +12
+ Misses 2341 2331 -10
+ Partials 893 882 -11
|
This was referenced Jun 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the backpressure support to
ReplaySubjectexposed a race condition around thecaughtUpoptimization.The problem occurs when the source thread has caught up after
drain()returned true but at the same time, a concurrentdrain()starts running (due to a subscribe() process finishing or requesting on top of the previousLong.MAX_VALUE). This concurrent drain may think the replay hasn't started yet (by findingrp.nodenull) or seeing that the buffer has more elements (that may get double emitted).The current solution is to remove this optimization until we come up with a correct optimization.
Related: #4028.