1.x: allow customizing GenericScheduledExecutorService via RxJavaHooks #4173
+136
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.08%@@ 1.x #4173 diff @@
==========================================
Files 262 263 +1
Lines 17048 17057 +9
Methods 0 0
Messages 0 0
Branches 2574 2574
==========================================
+ Hits 14247 14342 +95
+ Misses 1938 1872 -66
+ Partials 863 843 -20
|
| RxJavaHooks.setOnGenericScheduledExecutorService(null); | ||
|
|
||
| Schedulers.shutdown(); | ||
| // start() is package private so had to move this test here |
There was a problem hiding this comment.
Thanks, will clean it in the next coverage test PR.
|
👍 |
|
I'll have to redo this once #4182 is merged so please don't merge yet. |
akarnokd
force-pushed
the
RxJavaHookGenericSvc
branch
from
23a8479 to
021d34d
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a customization point to
RxJavaHooksthat let's one create differentScheduledExecutorServiceinstances for theGenericScheduledExecutorServiceutility.To apply the hook (or remove it), one has to restart the
Schedulersviashutdown()and thenstart(). Note that the latter had to be made public as well.Related #4171.