1.x: optimize collect, reduce and takeLast(1) #4176
Merged
+907
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,177 @@ | |||
| /** | |||
| * Copyright 2015 Netflix, Inc. | |||
There was a problem hiding this comment.
2016? The class this came from had 2016 as well
|
Updated header year, @JakeWharton . |
|
lgtm 👍 |
Current coverage is 81.42%@@ 1.x #4176 diff @@
==========================================
Files 257 261 +4
Lines 16823 16921 +98
Methods 0 0
Messages 0 0
Branches 2550 2554 +4
==========================================
+ Hits 13701 13778 +77
- Misses 2224 2247 +23
+ Partials 898 896 -2
|
|
/cc @artem-zinnatullin was it you that wanted more unit test coverage for the deferred-scalar algorithm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the overhead with
collect,reduceandtakeLastand introduces theDeferredScalarSubscriberto support similar unbounded-in single-out scenarios.Benchmark comparison (i7 4770K, Windows 7 x64, Java 8u92)
Relative to each other: (each practically returning the very last value)