1.x: fix assembly tracking replacing original exception #4215
+92
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.27%@@ 1.x #4215 diff @@
==========================================
Files 265 265
Lines 17281 17305 +24
Methods 0 0
Messages 0 0
Branches 2617 2624 +7
==========================================
+ Hits 14558 14583 +25
+ Misses 1881 1873 -8
- Partials 842 849 +7
|
|
👍 |
| * Finds an empty cause slot and assigns itself to it. | ||
| * @param exception the exception to start from | ||
| */ | ||
| public void attach(Throwable exception) { |
There was a problem hiding this comment.
attachTo, otherwise it looks like you're attaching exception to this while in fact it's vice versa
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the assembly tracking logic to not replace the exception flowing through but to attach the tracking exception to the end of the causal chain (if possible).
Fixes #4212