1.x: fix replay() retaining reference to the child Subscriber #4229
+103
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.20% (diff: 61.53%)@@ 1.x #4229 diff @@
==========================================
Files 265 265
Lines 17305 17314 +9
Methods 0 0
Messages 0 0
Branches 2624 2627 +3
==========================================
+ Hits 14559 14579 +20
+ Misses 1893 1884 -9
+ Partials 853 851 -2
|
|
This is a medium impact bug so it would be great if it made into tomorrow's release. /cc @artem-zinnatullin @zsxwing |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3470, a flat cache of Subscribers has been introduced that is versioned and gets only updated if there are new Subscribers coming, old Subscribers leaving and a value comes through - improving performance if lots of Subscribers come and go between main onNext signals. This cache is not cleared but rebuilt therefore child Subscribers unsubscribing were still referenced through it and everything beyond - leading to memory leak on sensitive systems.
The fix is to cut the link to the child Subscriber in
InnerProduceron unsubscription. A secondary action also empties the cache if all Subscribers are gone.Reported in #4228 .