OperatorAll - prevent multiple terminal events #4244
Merged
+125
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!done) { | ||
| done = true; | ||
| child.onError(e); | ||
| } |
There was a problem hiding this comment.
Call RxJavaHooks.onError so no exception is lost.
There was a problem hiding this comment.
Since you pointed it out in both PRs would not this also apply to some other places?
There was a problem hiding this comment.
Yes, anyplace that would drop the exception due to state/protocol considerations should instead call RxJavaHooks.onError.
davidmoten
force-pushed
the
operator-all-prevent-multiple-terminal-events
branch
from
8ff2bb0 to
4c8b0d8
Compare
|
Current coverage is 84.17% (diff: 100%)@@ 1.x #4244 diff @@
==========================================
Files 265 265
Lines 17319 17324 +5
Methods 0 0
Messages 0 0
Branches 2627 2629 +2
==========================================
+ Hits 14572 14583 +11
+ Misses 1893 1889 -4
+ Partials 854 852 -2
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #4242, if an operator maps an
onNextemission to anonErroremission downstream then it needs be defensive about anonCompletedbeing sent from upstream even if upstream has been unsubscribed.Includes a unit test that failed on the original code.