Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: concatDelayError multiple arguments #4261

Merged
merged 3 commits into from
Aug 10, 2016

Conversation

SherifMakhlouf
Copy link

This PR adds multiple arguments to concatDelayError operator

Related to: #4152

@codecov-io
Copy link

codecov-io commented Jul 31, 2016

Current coverage is 84.37% (diff: 100%)

Merging #4261 into 1.x will decrease coverage by 0.02%

@@                1.x      #4261   diff @@
==========================================
  Files           267        267          
  Lines         17460      17468     +8   
  Methods           0          0          
  Messages          0          0          
  Branches       2662       2662          
==========================================
+ Hits          14735      14738     +3   
- Misses         1866       1875     +9   
+ Partials        859        855     -4   

Powered by Codecov. Last update 969d94c...0d0cd28

@@ -1453,6 +1453,270 @@ public Completable toCompletable() {
}

/**
* Concatenates two Observables into a single sequence by subscribing to each Observable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the wording according to the plain concat methods as there are no outer and inner Observables with these methods?

@akarnokd
Copy link
Member

👍

@akarnokd
Copy link
Member

akarnokd commented Aug 3, 2016

@akarnokd akarnokd changed the title concatDelayError multiple arguments 1.x: concatDelayError multiple arguments Aug 3, 2016
@akarnokd akarnokd merged commit fabaa95 into ReactiveX:1.x Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants