doOnEach - reduce allocations, report to RxJavaHooks #4262
Merged
+315
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.41% (diff: 100%)@@ 1.x #4262 diff @@
==========================================
Files 267 268 +1
Lines 17460 17477 +17
Methods 0 0
Messages 0 0
Branches 2662 2662
==========================================
+ Hits 14735 14753 +18
Misses 1866 1866
+ Partials 859 858 -1
|
| @@ -5509,7 +5509,7 @@ public Completable toCompletable() { | |||
| Action1<Throwable> onError = Actions.empty(); | |||
| Observer<T> observer = new ActionSubscriber<T>(onNext, onError, onCompleted); | |||
davidmoten
force-pushed
the
doOnEach-optimize-and-fix
branch
from
d34fc7f to
771d859
Compare
|
fixed ActionSubscriber usage and removed empty test, ta |
|
👍 |
davidmoten
added a commit
to davidmoten/RxJava
that referenced
this pull request
Aug 2, 2016
This was referenced Aug 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #4260
RxJavaHooks.onErrorfor secondary errorsActionSubscriber->ActionObserver,Operator->OnSubscribe)