Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toMultimap - prevent post terminal emissions, reduce allocations #4270

Conversation

davidmoten
Copy link
Collaborator

  • switched to OnSubscribe
  • switched to use DeferredScalarSubscriberSafe
  • previous source failed to handle post terminal emissions
  • added 4 unit tests

@codecov-io
Copy link

codecov-io commented Aug 2, 2016

Current coverage is 84.43% (diff: 100%)

Merging #4270 into 1.x will increase coverage by 0.03%

@@                1.x      #4270   diff @@
==========================================
  Files           268        268          
  Lines         17475      17474     -1   
  Methods           0          0          
  Messages          0          0          
  Branches       2662       2664     +2   
==========================================
+ Hits          14750      14755     +5   
+ Misses         1867       1860     -7   
- Partials        858        859     +1   

Powered by Codecov. Last update c95c650...3b74be6

@akarnokd
Copy link
Member

akarnokd commented Aug 2, 2016

👍

@akarnokd akarnokd merged commit 515d7ce into ReactiveX:1.x Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants