1.x: add TestSubscriber.assertValuesAndClear #4322
Merged
+89
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.31% (diff: 80.00%)@@ 1.x #4322 diff @@
==========================================
Files 268 270 +2
Lines 17478 17517 +39
Methods 0 0
Messages 0 0
Branches 2664 2678 +14
==========================================
+ Hits 14764 14770 +6
- Misses 1853 1892 +39
+ Partials 861 855 -6
|
|
|
||
| try { | ||
| ts.assertAndConsume(4, 5, 6); | ||
| Assert.fail("Should have thrown AssertionError"); |
There was a problem hiding this comment.
nit: static import
There was a problem hiding this comment.
Does IntelliJ do that automatically? Eclipse doesn't so I have to go and manually type in the import; writing out Assert is more convenient for me. If you want, you can turn all of these into static imports in another PR.
There was a problem hiding this comment.
In IntelliJ I usually just write fail( and hit ALT + ENTER to apply static import, IntellIJ applies it for whole file then
|
👍 but method name, I just can't treat it as good for this API |
|
👍 |
akarnokd
changed the title
|
@JakeWharton / @zsxwing / @vanniktech can you PTAL? Would be great if we could include it in 1.1.9. |
|
Old method name was better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
assertAndConsumeassertValuesAndClearmethod toTestSubscriberto assert on value content and then clear the internal value list. This helps asserting on received values without the need to list all previously seen values inassertValues.On a sidenote,
getOnNextEvents()returns the internal list and one can callclear()on it.