Added Observable.concat(Iterable) #4330
Merged
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Before it was testing the same as testConcatWithObservableOfObservable
Current coverage is 84.51% (diff: 100%)@@ 1.x #4330 diff @@
==========================================
Files 268 268
Lines 17478 17479 +1
Methods 0 0
Messages 0 0
Branches 2664 2664
==========================================
+ Hits 14764 14773 +9
+ Misses 1853 1847 -6
+ Partials 861 859 -2
|
|
👍 |
|
👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4329
I also adjusted the test as it was testing the wrong thing before.