1.x: enhance generics doOnError doOnRequest #4555
Merged
+38
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.49% (diff: 100%)@@ 1.x #4555 diff @@
==========================================
Files 272 272
Lines 17571 17571
Methods 0 0
Messages 0 0
Branches 2683 2683
==========================================
- Hits 14855 14846 -9
- Misses 1864 1868 +4
- Partials 852 857 +5
|
JakeWharton
approved these changes
Sep 14, 2016
davidmoten
force-pushed
the
doOnError-doOnRequest-enhance-generics
branch
from
4338e16 to
85aa0ee
Compare
I've added a couple of tests to get coverage of new lower bounds. |
|
Is it okay if this goes into 1.2 only ? Technically this isn't a behavior change but an API change, and besides o f |
|
OK with me to go in 1.2. |
|
Oh, something conflicted. Could you rebase? |
davidmoten
force-pushed
the
doOnError-doOnRequest-enhance-generics
branch
from
85aa0ee to
03b9529
Compare
|
rebased. |
|
Thanks 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
want to able to call
doOnError(Action1<Object>)and similarly enhanceddoOnRequestwhile I was about it.